Add deadLetterPolicy to PulsarListener #88
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpreu
commented
Sep 6, 2022
spring-pulsar/src/main/java/org/springframework/pulsar/core/DefaultPulsarConsumerFactory.java
Show resolved
Hide resolved
|
@alpreu, this is cool. I will start reviewing this PR soon. |
onobc
requested changes
Sep 6, 2022
spring-pulsar/src/main/java/org/springframework/pulsar/annotation/PulsarListener.java
Outdated
Show resolved
Hide resolved
spring-pulsar/src/main/java/org/springframework/pulsar/core/DefaultPulsarConsumerFactory.java
Show resolved
Hide resolved
...src/main/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainer.java
Show resolved
Hide resolved
.../java/org/springframework/pulsar/listener/ConcurrentPulsarMessageListenerContainerTests.java
Outdated
Show resolved
Hide resolved
.../java/org/springframework/pulsar/listener/ConcurrentPulsarMessageListenerContainerTests.java
Show resolved
Hide resolved
.../java/org/springframework/pulsar/listener/ConcurrentPulsarMessageListenerContainerTests.java
Outdated
Show resolved
Hide resolved
...est/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainerTests.java
Outdated
Show resolved
Hide resolved
...est/java/org/springframework/pulsar/listener/DefaultPulsarMessageListenerContainerTests.java
Show resolved
Hide resolved
spring-pulsar/src/test/java/org/springframework/pulsar/listener/PulsarListenerTests.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Sep 6, 2022
spring-pulsar/src/test/java/org/springframework/pulsar/listener/PulsarListenerTests.java
Outdated
Show resolved
Hide resolved
onobc
approved these changes
Sep 6, 2022
|
Thanks for the awesome PR @alpreu . I have fixed conflict locally but when I run all tests I get a failure in PulsarListenerTests (of course works fine when run by itself). PulsarListenerTests > DeadLetterPolicyTest STANDARD_OUT
12:29:31.220 [Test worker] ERROR org.springframework.pulsar.listener.DefaultPulsarMessageListenerContainer - Pulsar client exceptions.
org.apache.pulsar.client.api.PulsarClientException$IncompatibleSchemaException: {"errorMsg":"Incompatible schema: exists schema type INT32, new schema type STRING","reqId":2109641079268052675, "remote":"localhost/127.0.0.1:51249", "local":"/127.0.0.1:51436"}
at org.apache.pulsar.client.api.PulsarClientException.unwrap(PulsarClientException.java:1014) ~[pulsar-client-api-2.10.1.jar:2.10.1]
at org.apache.pulsar.client.impl.ConsumerBuilderImpl.subscribe(ConsumerBuilderImpl.java:101) ~[pulsar-client-2.10.1.jar:2.10.1]
at org.springframework.pulsar.core.DefaultPulsarConsumerFactory.createConsumer(DefaultPulsarConsumerFactory.java:104) ~[main/:?]
at org.springframework.pulsar.listener.DefaultPulsarMessageListenerContainer$Listener.<init>(DefaultPulsarMessageListenerContainer.java:191) ~[main/:?]
at org.springframework.pulsar.listener.DefaultPulsarMessageListenerContainer.doStart(DefaultPulsarMessageListenerContainer.java:95) ~[main/:?]
at org.springframework.pulsar.listener.AbstractPulsarMessageListenerContainer.start(AbstractPulsarMessageListenerContainer.java:169) ~[main/:?]
at org.springframework.pulsar.listener.ConcurrentPulsarMessageListenerContainer.doStart(ConcurrentPulsarMessageListenerContainer.java:83) ~[main/:?]
at org.springframework.pulsar.listener.AbstractPulsarMessageListenerContainer.start(AbstractPulsarMessageListenerContainer.java:169) ~[main/:?]
at org.springframework.pulsar.config.PulsarListenerEndpointRegistry.startIfNecessary(PulsarListenerEndpointRegistry.java:239) ~[main/:?]
at org.springframework.pulsar.config.PulsarListenerEndpointRegistry.start(PulsarListenerEndpointRegistry.java:191) ~[main/:?]
at org.springframework.context.support.DefaultLifecycleProcessor.doStart(DefaultLifecycleProcessor.java:178) ~[spring-context-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at org.springframework.context.support.DefaultLifecycleProcessor$LifecycleGroup.start(DefaultLifecycleProcessor.java:356) ~[spring-context-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]I am going to merge as @sobychacko is going to build on top of this work. @sobychacko can you follow up w/ the test failure? |
|
Closed via 25dcfab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to add DeadLetterPolicy beans to the PulsarListener annotation (#79).
Mostly based on Soby's work done in #85